That was a bit of an arrogant and naive statement Snow made when she said that when you do good, good things come your way (or something like that) because Regina was good, and still lost the love of her life.
In this world Regina was written as the villain long before she was actually a villain.
As for Anna's attitude speech (granted she was under a spell) was annoying. It was not Elsa's fault that she pushed Anna away. Their parents drove them apart and basically imprisoned Else in her room as well as a shroud of shame for having magic.